fix for error when item is not in first page #320

jacalata · 2024-12-21T08:18:05Z

I pushed the parent-project filter into the request so we only get the results that match, this means the result we want will always be on the first page (and will coincidentally improve performance of most queries by some extent)

We should rename this method [and others] to make it clear they will return exactly one item or throw an error.

github-actions · 2024-12-21T08:18:43Z

Coverage Report

File	Stmts	Miss	Cover	Missing
tabcmd
__main__.py	10	10	10	0%
tabcmd.py	14	14	14	0%
version.py	6	3	3	50%
tabcmd/commands
commands.py	10	10	10	0%
constants.py	77	15	15	81%
server.py	130	20	20	85%
tabcmd/commands/auth
session.py	360	42	42	88%
tabcmd/commands/datasources_and_workbooks
datasources_and_workbooks_command.py	127	16	16	87%
datasources_workbooks_views_url_parser.py	140	10	10	93%
delete_command.py	60	16	16	73%
export_command.py	114	25	25	78%
get_url_command.py	127	47	47	63%
publish_command.py	82	24	24	71%
runschedule_command.py	21	7	7	67%
tabcmd/commands/extracts
create_extracts_command.py	42	8	8	81%
decrypt_extracts_command.py	27	2	2	93%
delete_extracts_command.py	37	6	6	84%
encrypt_extracts_command.py	27	2	2	93%
extracts.py	20	2	2	90%
reencrypt_extracts_command.py	27	2	2	93%
refresh_extracts_command.py	48	13	13	73%
tabcmd/commands/group
create_group_command.py	29	5	5	83%
delete_group_command.py	27	2	2	93%
tabcmd/commands/project
create_project_command.py	46	8	8	83%
delete_project_command.py	35	4	4	89%
publish_samples_command.py	30	4	4	87%
tabcmd/commands/site
create_site_command.py	34	5	5	85%
delete_site_command.py	28	2	2	93%
edit_site_command.py	38	2	2	95%
list_command.py	44	10	10	77%
list_sites_command.py	29	2	2	93%
tabcmd/commands/user
create_site_users.py	57	10	10	82%
create_users_command.py	60	10	10	83%
delete_site_users_command.py	43	5	5	88%
user_data.py	221	31	31	86%
tabcmd/execution
_version.py	2	2	2	0%
global_options.py	145	23	23	84%
localize.py	69	11	11	84%
logger_config.py	42	6	6	86%
tabcmd_controller.py	41	6	6	85%
TOTAL	2704	442	84%

I pushed the parent-project filter into the request so we only get the results that match. We should rename this method [and others] to make it clear they will return one item or throw an error.

tabcmd/commands/server.py

fix for error when item is not in first page

0075f17

I pushed the parent-project filter into the request so we only get the results that match. We should rename this method [and others] to make it clear they will return one item or throw an error.

jacalata force-pushed the jac/improve-not-found branch from ecf5eb1 to 0075f17 Compare December 21, 2024 08:19

jacalata requested a review from renoyjohnm December 21, 2024 08:19

fix query filter for projects

ce4048e

jacalata force-pushed the jac/improve-not-found branch from 0294929 to ce4048e Compare December 23, 2024 22:23

renoyjohnm reviewed Dec 27, 2024

View reviewed changes

tabcmd/commands/server.py Show resolved Hide resolved

renoyjohnm approved these changes Dec 27, 2024

View reviewed changes

jacalata merged commit 3be7100 into development Dec 27, 2024
18 checks passed

jacalata deleted the jac/improve-not-found branch January 3, 2025 04:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix for error when item is not in first page #320

fix for error when item is not in first page #320

jacalata commented Dec 21, 2024 •

edited

Loading

github-actions bot commented Dec 21, 2024 •

edited

Loading

fix for error when item is not in first page #320

fix for error when item is not in first page #320

Conversation

jacalata commented Dec 21, 2024 • edited Loading

github-actions bot commented Dec 21, 2024 • edited Loading

jacalata commented Dec 21, 2024 •

edited

Loading

github-actions bot commented Dec 21, 2024 •

edited

Loading